Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ESLint issues in botbuilder #4830

Merged
merged 9 commits into from
Jan 6, 2025
Merged

fix: ESLint issues in botbuilder #4830

merged 9 commits into from
Jan 6, 2025

Conversation

JhontSouth
Copy link
Collaborator

@JhontSouth JhontSouth commented Dec 20, 2024 •
edited
Loading

Addresses #4684
#minor

Description

This PR fixes the new ESLint issues after upgrading the ESLint packages in the botbuilder library.

Specific Changes

  • Removed botbuilder eslint.config.cjs file.
  • Applied the fixes needed for all the issues detected by ESLint.
  • Removed duplicated unit test in teamsActivityHandler.test.

Testing

The following image shows the issues fixed in the library.
image

@JhontSouth JhontSouth requested a review from a team as a code owner December 20, 2024 17:01
@coveralls
Copy link

coveralls commented Dec 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12435386722

Details

  • 18 of 23 (78.26%) changed or added relevant lines in 11 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 84.622%
Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder/src/botFrameworkAdapter.ts 7 8 87.5%
libraries/botbuilder/src/skills/cloudSkillHandler.ts 0 1 0.0%
libraries/botbuilder/src/skills/skillHttpClient.ts 0 1 0.0%
libraries/botbuilder/src/cloudAdapter.ts 1 3 33.33%
Totals Coverage Status
Change from base Build 12259066809: -0.003%
Covered Lines: 20515
Relevant Lines: 23094
💛 - Coveralls

@tracyboehrer tracyboehrer merged commit a36641b into main Jan 6, 2025
16 checks passed
@tracyboehrer tracyboehrer deleted the southworks/fix/eslint-issues-botbuilder branch January 6, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tracyboehrer tracyboehrer tracyboehrer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JhontSouth @coveralls @tracyboehrer